vendor- and/or vaccine- and/or disease-specific examples should be genericized

[TallTed]

COVID-19 and Moderna Biotech and the like should not be hardcoded into example data, any more than real people or real websites or real email addresses or real phone numbers.

All such things should be genericized and anonymized, as I tried to do in https://github.com/w3c-ccg/universal-wallet-interop-spec/pull/61, but that was generated from here, so I'm here.

[dpjanes]

Diseases and Drugs are coded both in schema.org and in FHR: that is, expressed as a pair of values - the code value and the code system.

I would strongly suggest moving away from eg

    "vaccine": {
      "type": "Vaccine",
      "disease": "COVID-19",
      "atcCode": "J07BX03",
      "medicinalProductName": "COVID-19 Vaccine Moderna",
      "marketingAuthorizationHolder": "Moderna Biotech"
    }

C4 codes it like this - which I do understand is more complex than preferred - but maybe disease (e.g. U07), diseaseCode (ICD-10), drug (J07BX03) and drugCode (ATC) are preferable to these sorts of adhoc fields?

{
      "@type": "schema:ImmunizationRecommendation",
      "schema:drug": {
        "@type": "schema:Drug",
        "schema:code": {
          "@type": "schema:MedicalCode",
          "schema:codeValue": "207",
          "schema:codingSystem": "CVX"
        },
        "schema:manufacturer": {
          "@type": "schema:Organization",
          "schema:identifier": "MOD",
          "schema:name": "Moderna US, Inc."
        },
        "schema:name": "Moderna COVID-19 Vaccine"
      },
      "schema:healthCondition": {
        "@type": "schema:MedicalCondition",
        "schema:code": {
          "@type": "schema:MedicalCode",
          "schema:codeValue": "U07",
          "schema:codingSystem": "ICD-10"
        },
        "schema:name": "COVID-19"
      },
      "schema:name": "Moderna COVID-19 Vaccine"
    }

[TallTed]

@dpjanes - I have no specific objection to your changes, but they do not address this issue as I have raised it. (I am also confused about your mention of disease, diseaseCode, and drugCode, which are not then included in your example JSON-LD.) I wonder if your comment wouldn't be better as the start of a distinct issue...

To be explicit about this issue:

• Moderna should not be named in sample data. Example Corp would be a better choice.
• COVID-19 would be better not named in sample data. Example Disease would be a better choice.

[dpjanes]

Ah, I was thinking your issue was something else sorry. Note the things I used were e.g. here's how it could be done in the spirit of this system rather than reusing more verbose stuff that's already out there.