search

w3c-ccg / vc-api-test-suite

The VC HTTP API Test Suite
https://w3c-ccg.github.io/vc-api-test-suite/
Other
4 stars 8 forks source link

"checks" is not a valid option in /verify endpoints #8

Closed peacekeeper closed 2 years ago

peacekeeper commented 3 years ago

The test suite currently sends an option named "checks" to the Verifier endpoints, e.g. see here:

https://github.com/w3c-ccg/vc-http-api-test-suite/blob/main/packages/vc-http-api-test-server/__tests__/verifyCredential.spec.js#L19

However, this is not a valid option in the current API:

https://github.com/w3c-ccg/vc-http-api/blob/main/components/VerifyOptions.yml#L15

We discussed this on the 05 Oct 2021 VC API Work Item call and felt that variability of checks is bad, i.e. there should be a fixed set of checks that each conformant implementation of the API performs, and any additional business logic (e.g. evaluating if a VP matches a certain request) should happen outside of the API. There would therefore be no need for a registry of checks, or for options that the client could supply in the request for enabling/disabling certain checks.

Also see https://github.com/w3c-ccg/vc-http-api/issues/62 and https://github.com/w3c-ccg/vc-http-api/issues/59.

Based on this, we should create a PR to remove "checks" from the test suite.

peacekeeper commented 2 years ago

Closing since https://github.com/w3c-ccg/vc-api-test-suite/pull/9 has been merged.