w3c-ccg / vc-api-verifier-test-suite

Test Suite for Verifiers that implement the VC HTTP API
https://w3c-ccg.github.io/vc-api-verifier-test-suite/
4 stars 6 forks source link

Suite sends expired credentials as valid documents to verify #20

Closed filip26 closed 2 years ago

filip26 commented 2 years ago

Hi, I've tried to test vc-http-api with this suite, the first test: ❌ MUST verify a valid VC.

has failed, but when I checked the tested document I've found that it's expired

{

    "verifiableCredential": {
      "id": "urn:uuid:797f719c-e4ac-4e9e-8da8-bc60a9c8ba91",
      "expirationDate": "2022-05-31T19:21:25Z",
      "@context": [
        "https://www.w3.org/2018/credentials/v1",
        "https://w3id.org/security/suites/ed25519-2020/v1"
      ],
      "type": [
        "VerifiableCredential"
      ],
      "proof": {
        "verificationMethod": "did:key:z6MkiVQTYk3L2XKY6yg6MyeN2QLE5QkKcXByUeY1dkdiLx4j#z6MkiVQTYk3L2XKY6yg6MyeN2QLE5QkKcXByUeY1dkdiLx4j",
        "created": "2022-03-31T19:21:26Z",
        "proofPurpose": "assertionMethod",
        "proofValue": "z4ngCxM3oqs6Fxq4NcgzXT8XugTK92EeHxkux8CjdZwSbFqMZVDQqBJcXb3MUcfbDWzsCoDA3pYAYJDqYbCtMvXxz",
        "type": "Ed25519Signature2020"
      },
      "issuanceDate": "2022-03-31T19:21:25Z",
      "issuer": "did:key:z6MkiVQTYk3L2XKY6yg6MyeN2QLE5QkKcXByUeY1dkdiLx4j",
      "credentialSubject": {
        "id": "did:key:z6MkhTNL7i2etLerDK8Acz5t528giE5KA4p75T6ka1E1D74r"
      }
    },
    "options": {
      "checks": [
        "proof"
      ]
    }

}

and vc-http-api has rejected the VC with EXPIRED code.

JSAssassin commented 2 years ago

Thanks @filip26 for catching this. This PR - https://github.com/w3c-ccg/vc-api-verifier-test-suite/pull/21 will address the issue.

JSAssassin commented 2 years ago

Closing, this has been addressed.