search

w3c-ccg / vc-api

A specification for an HTTP API used to issue and verify Verifiable Credentials.
https://w3c-ccg.github.io/vc-api
Other
123 stars 47 forks source link

cleanup issueCredentialOptions and VerifyOptions #375

Closed mkhraisha closed 6 months ago

mkhraisha commented 6 months ago

Forked off #373 tackles #318

Merge conflicts will be cleaned up once once #373 is merged in.

Challenge changes are not intended to be reviewed in this PR, but are remnants from forking off #373.

  1. Updates IssueCredentialOptions to remove created, and updates the example
  2. Updates DeriveCredentialOptions to add selectivePointers
  3. Removes VerifyOptions this has now been split into:
  4. VerifyCredentialOptions: this currently only has returnCredential which is based on what the current spec shows.
  5. VerifyPresentationOptions: this currently has the properties domain and challenge. The issue mentions adding proofPurpose, but I wasn't sure, iirc the proofPurpose of a presentation is always authentication. if that is not true happy to update the PR. The Spec also mentions returnCredential as a possible option to this endpoint, I'm not sure if thats an error that should be returnPresentation or it should just be excluded entirely, I erred on the side of exclusion.
  6. CreatePresentationOptions: intended to provide options when creating a presentation, similar question on the proofPurpose field.
  7. Updates references that call VerifyOptions.

Preview | Diff Don't remove this comment or modify anything below this line. If you don't want a preview generated for this pull request, just replace the whole of this comment's content by "no preview" and remove what's below. -->

Preview (#Don't…) (<a href="https://pr-preview.s3.amazonaws.com/w3c-ccg/vc-api/pull/375.html#just replace the whole of this comment's content by "no preview" and remove what's below.

-->

<a href="https://pr-preview.s3.amazonaws.com/w3c-ccg/vc-api/pull/375.html" title="Last updated on Mar 5" title="#just replace the whole of this comment's content by "no preview" and remove what's below.

-->

#just…) (#2024) (Preview | Preview | #9:44…) (#2024) (Diff" title="#9:44 PM UTC (ebd12e1)">Diff">#9:44…) | Diff

msporny commented 6 months ago

@mkhraisha the group reviewed this today, looks like it's on a good path, we're getting ready to merge 373, please re-base once that happens and we'll merge this one as well. Thank you for the PR!

msporny commented 6 months ago

Re-ping @mkhraisha, please re-base, we'd like to merge your PR.

mkhraisha commented 6 months ago

Rebased, hopefully this works now.