w3c-ccg / vc-ed-models

https://w3c-ccg.github.io/vc-ed-models/
Other
9 stars 5 forks source link

Update hasAchieved to existing schema.org term hasCredential #13

Closed ottonomy closed 3 years ago

ottonomy commented 3 years ago

http://schema.org/hasCredential is an existing term in the schema.org vocabulary. This PR attempts to update our models to use that existing term instead of inventing our own for the same concept, following from discussions on the task force calls.

anthonycamilleri commented 3 years ago

I understand the logic of this, but it seems that if we take this hasCredential approach, we are creating significant definitional confusion.

My initial reaction here was that we were putting a full embedded credential inside a VC credential. I appreciate schema.org uses hasCredential but since a credential has a different definition within a Verifiable Crednential context, and that a BadgeClass is not a credential in a VC sense, it would seem to me that the original proposal has more merit.

Furthermore what is the purpose of this class? Is it meant to store information about achievements which may be gained (in the sense of a badgeclass), the assertion that a student has actually gained those achievements, or both?

Simple example from formal education: where does the grade go?