search

w3c-ccg / vc-ed-models

https://w3c-ccg.github.io/vc-ed-models/
Other
9 stars 5 forks source link

update GitHub Action to include static files #15

Closed jchartrand closed 3 years ago

jchartrand commented 3 years ago

Addresses issue #9

Note that this copies the static files (from main to gh-pages) as a separate commit from the w3c/spec-prod@v1 commit of the index.html to gh-pages. To get both in the same commit we'd have to modify w3c/spec-prod@v1

I tried to follow the commit format used by the w3c/spec-prod@v1 action. Let me know if anything should be changed.

I also wonder if we shouldn't get rid of the .github/workflows directory in the gh-pages branch? I don't think it is doing anything? Same goes for the index.bs file in gh-pages.

jchartrand commented 3 years ago

@kimdhamilton

I merged the PR which again produced an error in the GitHub action, but I’m hopeful that error is still a permissions thing, and now that the action is part of the repository proper, the next run of the action should work (it works fine in my fork of the repo)

I will update the bike shed file in the next couple days to test.

On Nov 4, 2020, at 2:20 PM, Kim (Hamilton) Duffy notifications@github.com wrote:

@kimdhamilton approved this pull request.

LGTM; thanks @jchartrand https://github.com/jchartrand!

I agree with what you said about the files to get rid of. They shouldn't need to be in gh-pages

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/w3c-ccg/vc-ed-models/pull/15#pullrequestreview-523664845, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEFSXO5TS4ZTE2UEKOS2STSOGSOXANCNFSM4TKLYP5A.