search

w3c-ccg / vc-test-suite-implementations

Implementations for VC HTTP API tests
BSD 3-Clause "New" or "Revised" License
0 stars 11 forks source link

Remove `Ed25519Signature2018` tags from implementations #95

Closed JSAssassin closed 9 months ago

JSAssassin commented 9 months ago

None of the test suites uses this tag and also Ed25519Signature2018 is no longer supported.

Question though is do we want to remove the implementations that have the tag vc-api with option Ed25519Signature2018? I believe they are issuing VCs with Ed25519Signature2018 proof type.

Mavennet and Danube Tech uses Ed25519Signature2018 option for their vc-api implementations.

NOTE: I am able to change the options type to "Ed25519Signature2020" for Danube Tech and they are able to issue a VC with Ed25519Signature2020 proof type but for Mavennet even when I change the options type, it still issues a VC with Ed25519Signature2018. The vc-api implementations for EWF and SecureKey are also generating VCs with Ed25519Signature2018. What actions should we take regarding these?

Edited - For now I have added a note in README.md that states that Ed25519Signature2018 is no longer supported so if any of the implementers were using that previously they should now update their implementations to use Ed25519Signature2020 64d04d7, also opened an issue here https://github.com/w3c-ccg/vc-test-suite-implementations/issues/97