search

w3c-fedid / FedCM

A privacy preserving identity exchange Web API
https://w3c-fedid.github.io/FedCM/
Other
375 stars 72 forks source link

Merge login() into get() and remove logout() and revoke() #279

Closed samuelgoto closed 2 years ago

samuelgoto commented 2 years ago

:boom: Error: 500 Internal Server Error :boom:

PR Preview failed to build. (Last tried on Jun 17, 2022, 11:21 PM UTC).

More PR Preview relies on a number of web services to run. There seems to be an issue with the following one: :rotating_light: [HTML Diff Service](http://services.w3.org/htmldiff) - The HTML Diff Service is used to create HTML diffs of the spec changes suggested in a pull request. :link: [Related URL](https://services.w3.org/htmldiff?doc1=https%3A%2F%2Fpr-preview.s3.amazonaws.com%2Ffedidcg%2FFedCM%2Fpull%2F279%2F7478f19.html&doc2=https%3A%2F%2Fpr-preview.s3.amazonaws.com%2Ffedidcg%2FFedCM%2Fpull%2F279.html) ``` 500 Internal Server Error

Internal Server Error

The server encountered an internal error or misconfiguration and was unable to complete your request.

Please contact the server administrator at sysreq@w3.org to inform them of the time this error occurred, and the actions you performed just before this error.

More information about this error may be available in the server error log.

``` _If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20fedidcg/FedCM%23279.)._
npm1 commented 2 years ago

LGTM with the nits I pointed out. It's harder to review if you resolve unresolved comments, as then I have to go over all.

samuelgoto commented 2 years ago

The HTML preview is failing, but I think it is a server error, rather than a spec error. Will merge and see if I break anything.