search

w3c-fedid / FedCM

A privacy preserving identity exchange Web API
https://w3c-fedid.github.io/FedCM/
Other
375 stars 72 forks source link

[Editorial] IdentityCredential methods should throw errors, not return them #295

Closed nsatragno closed 2 years ago

nsatragno commented 2 years ago

IdentityCredential's methods should throw errors, not return them.'

DiscoverFromExternalSource should throw exceptions / errors instead of returning them. We somewhat recently changed this here https://github.com/w3c/webappsec-credential-management/pull/196 to better support AbortController's reason.

npm1 commented 2 years ago

Looks like most of failure modes are currently being thrown as NetworkErrors. Addressed that in PR