w3c-fedid / FedCM

A privacy preserving identity exchange Web API
https://w3c-fedid.github.io/FedCM/
Other
375 stars 72 forks source link

[Editorial] Better specify DiscoverFromExternalSource override #300

Closed nsatragno closed 2 years ago

nsatragno commented 2 years ago

The spec says

To do so, this specification does three things: ... Lastly, it overrides the default implementation of § 7.4 The [[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors) internal method.

It's not clear from that if the IdentityCredential type defined happens to override that method (which is what's going on) or, that this specification defines a new implementation for Credential's DiscoverFromExternalSource, which is absolutely not what you intended.

Better wording is something along the lines of:

This specification introduces a new Credential interface {{IdentityCredential}}. {{IdentityCredential}} overrides the Credential's DiscoverFromExternalSource algorithm.

Another change is on the algorithm name & definition, the spec should call out this is IdentityCredential's DiscoverFromExternalSource that it's talking about:

Instead of

7.4. The [[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors) internal method

Maybe

7.4. {{IdentityCredential}}'s [[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors) internal method