Add fetch calls - Githubissues

w3c-fedid / FedCM

A privacy preserving identity exchange Web API

https://w3c-fedid.github.io/FedCM/

Other

375 stars 72 forks source link

Add fetch calls #356

Closed npm1 closed 2 years ago

npm1 commented 2 years ago

Relevant issues:

https://github.com/fedidcg/FedCM/issues/261
https://github.com/fedidcg/FedCM/issues/320

This PR adds the fetch calls to the other FedCM fetches.

Preview | Diff

npm1 commented 2 years ago

PTAL, addressed all of your comments. The pending thing is the referrer being handwavy (in the case we do want to send it), while I figure out how to set it properly.

npm1 commented 2 years ago

Ready for more review, PTAL.

npm1 commented 2 years ago

Looks generally good to me, but still feels like the parameters aren't quite right.

On a separate note, any chance we can get @domfarolino to take a pass at this too?

Can you look again but looking at the latest version??

npm1 commented 2 years ago

Added Sec- header changes

samuelgoto commented 2 years ago

LGTM

I'll merge, and if there is anything pending we can patch separately.