Account Picture not defined in IDL and no semantics provided

w3c-fedid / FedCM

A privacy preserving identity exchange Web API

https://w3c-fedid.github.io/FedCM/

Other

375 stars 72 forks source link

Account Picture not defined in IDL and no semantics provided #406

Closed bvandersloot-mozilla closed 1 year ago

bvandersloot-mozilla commented 1 year ago

Speaking of the following struct: https://fedidcg.github.io/FedCM/#dictdef-identityprovideraccount.

The semantics of the picture variable are missing and are not included in the IDL.

npm1 commented 1 year ago

Oh! Great catch, Ben. I thought I may have removed it accidentally recently or something but looking at previous history it seems it hasn't been there for a long time (maybe never added).

bvandersloot-mozilla commented 1 year ago

Yeah, I was surprised to see I hadn't added it with the IDL and then noticed it wasn't in the list below.

I'd file a patch to fix this, but I don't know what your rules on the URL are (absolute vs relative in particular).

npm1 commented 1 year ago

I sent a patch though waiting for Christian to check it :) AFAICT it requires absolute URLs and the fetch is done from the broweser, i.e. there is no referer etc. I do not see us setting the request's destination though.