Closed npm1 closed 1 year ago
Why was the mime type requirement removed? It seems like a good spec element to have and is supported in Mozilla's prototype. That part sounds like a Chrome bug rather than a spec error.
Hey Ben, hmm yea I removed it because it does not seem to be implemented in Chrome. I do not feel strongly about it. If you think this should be readded, I can do that and instead file a Chrome bug.
Yeah, that sounds like a good resolution.
On Wed, Feb 1, 2023 at 8:34 AM npm1 @.***> wrote:
Hey Ben, hmm yea I removed it because it does not seem to be implemented in Chrome. I do not feel strongly about it. If you think this should be readded, I can do that and instead file a Chrome bug.
— Reply to this email directly, view it on GitHub https://github.com/fedidcg/FedCM/pull/412#issuecomment-1412357911, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFJL2WTVV3VSZMVYHB2IDLWVKGB5ANCNFSM6AAAAAAULWRPVI . You are receiving this because you modified the open/close state.Message ID: @.***>
-- f u cn rd ths u cn b a gd prgmr !
I noticed that processResponseConsumeBody receives a
response
and a 'responseBody', which may be null, failure, or a byte sequence. That one should be used instead of reading off of theresponse
body. Also, get rid of mime type checking as it seems unimplemented in Chrome. Fixes https://github.com/fedidcg/FedCM/issues/409Preview | Diff