w3c-fedid / FedCM

A privacy preserving identity exchange Web API
https://w3c-fedid.github.io/FedCM/
Other
373 stars 72 forks source link

Decide how to handle signin dialog closure for the IDP signin status API #419

Closed cbiesinger closed 5 months ago

cbiesinger commented 1 year ago

The IDP signin status API expects to show a IDP signin dialog popup of some kind. The question is how to close this dialog once the user is done.

We can not close this dialog once we receive this header because the signin flow may not be done yet -- there may be interstitials such as verifying your phone number is up-to-date, etc.

Options:

cbiesinger commented 1 year ago

Interested in any thoughts on these options. (@bvandersloot-mozilla maybe?)

bvandersloot-mozilla commented 1 year ago

I was imagining the IDP to get a Promise when it calls IDP.login() that resolves when the user closes the dialog. Then it is the IDP's responsibility to close it, presumably with window.close(). Or is this a different signin dialog?

cbiesinger commented 1 year ago

I'm not sure that's workable... 1) that does not work if the IDP uses the header, and 2) I think that login flows will typically be across multiple pages

cbiesinger commented 1 year ago

Sorry, I misunderstood. Yes that will work, if we make window.close() work for this dialog

tttzach commented 5 months ago

We have introduced IdentityProvider.close() for this purpose. Closing for now.