search

w3c-fedid / FedCM

A privacy preserving identity exchange Web API
https://w3c-fedid.github.io/FedCM/
Other
375 stars 72 forks source link

Correctly handle fetch errors #455

Closed cbiesinger closed 1 year ago

cbiesinger commented 1 year ago

The extract and convert steps can throw exceptions, but fetch's processResponseConsumeBody does not really handle that. Instead, set the respective return objects to failure and update the call site where necessary.

This was split out of PR #453 with major modifications.

Preview | Diff

cbiesinger commented 1 year ago

@martinthomson, @bvandersloot-mozilla and @cboozar -- FYI, but I don't expect this to be controversial.

cbiesinger commented 1 year ago

This text is incorrect, please hold off on reviewing until I have fixed it

cbiesinger commented 1 year ago

OK this should be ready for review now.

cbiesinger commented 1 year ago

fine to merge IMO

(I personally do not have permission to merge stuff here)