Closed RByers closed 2 months ago
@cbiesinger PTAL. If there's agreement that this is correct, then I'll also update chromium to make providers
required.
Looks good except that I am not sure if we need to create the exception in a task
I think this change makes sense but it actually does not match Chromium implementation (required
is missing from the IDL file). I guess the only difference is that the implementation currently will just silently return a trivial promise instead of throwing an error.
Filed https://bugs.chromium.org/p/chromium/issues/detail?id=1440522 by the way.
This is still relevant. Are you planning on addressing the comments or should I start a new PR for this?
I see spec now has 'required' which we added elsewhere already. This also asserts the size, which we would get rid of when we add multi IDP support. So closing this
Make
providers
required in theidentity
options dictionary so that the assert is true. Replace theproviders
size assert with an explicit check and throw, matching chromium code.Preview | Diff