search

w3c-fedid / FedCM

A privacy preserving identity exchange Web API
https://w3c-fedid.github.io/FedCM/
Other
375 stars 72 forks source link

Should getUserInfo() be under IdentityProvider? #476

Closed npm1 closed 2 months ago

npm1 commented 1 year ago

Per https://github.com/fedidcg/FedCM/pull/470 review, it is awkward to have getUserInfo() hang off of IdentityProvider. However, we currently do not really have any better ideas. While we are for now keeping it there, filing this issue to keep this open for the next few months, while it is still easy to move it around, in case we find a better home for it.

samuelgoto commented 1 year ago

The other option we considered was hanging it on IdentityCredential as a static method, but (a) there are more methods that we'd need to find a better home to and (b) it may not fit well with this design too.

There are a few moving parts here (example), but I agree that IdentityProvider.getUserInfo() is awkward.

We are committed to moving this to a better place if we can find one while FedCM is still in its early days of adoption (say, in the next 6-12 months it should be easy to move it to another object if we find one).

tttzach commented 2 months ago

We decided that since getUserInfo is called from an IDP origin, then it should probably live in IdentityProvider. Closing for now.