search

w3c-fedid / FedCM

A privacy preserving identity exchange Web API
https://w3c-fedid.github.io/FedCM/
Other
375 stars 72 forks source link

Make providers required in IdentityCredentialRequestOptions #480

Closed npm1 closed 1 year ago

npm1 commented 1 year ago

@bvandersloot-mozilla WDYT

Preview | Diff

bvandersloot-mozilla commented 1 year ago

This doesn't actually make much difference functionally- The list can still be empty. It does remove one of two empty list cases, so I don't mind the change.

samuelgoto commented 1 year ago

Why is this needed?

I'm wondering how it relates to Adam's PR5 and if it makes it easier/harder.

cbiesinger commented 1 year ago

It is not strictly "needed" but it makes the IDL reflect the semantics better and could provide a slightly better error message (from bindings code) if JS code does not provide a providers property.

Adam's proposal is unaffected as written.

npm1 commented 1 year ago

What Christian said :)

npm1 commented 1 year ago

Ping

bvandersloot-mozilla commented 1 year ago

LGTM