Change various "sign in" to "login"

w3c-fedid / FedCM

A privacy preserving identity exchange Web API

https://w3c-fedid.github.io/FedCM/

Other

375 stars 72 forks source link

Change various "sign in" to "login" #507

Closed cbiesinger closed 1 year ago

cbiesinger commented 1 year ago

Most notably, the signin_url field is renamed to login_url to match the spec.

samuelgoto commented 1 year ago

LGTM

Do we still actually need this explainer now that the spec is patched?

cbiesinger commented 1 year ago

I think the explainer is still useful as a more concise description of the feature. (Note how the blink launch process needs explainers even when the spec PR has landed...)

Anyway, your suggestion is committed, so this is ready for merging.