Closed tttzach closed 11 months ago
Can we split the error API parts into a different PR? and land those when the error API is part of the spec? It's a bit difficult to describe ErrorGotIt and ErrorMoreDetails without referencing them.
Also the error codes refer to https://w3c.github.io/webdriver/#dfn-error-code. (Nope no warning on make but [=error dialog=] shows up as regular text without a hyperlink on the index.html)
Sorry yes, that's what I meant -- remove those parts from this PR and land them together with or after the general error API PR. (I shouldn't have said "codes", I meant ErrorGotIt and ErrorMoreDetails, but I think we're on the same page)
Weird that the [=error dialog=] thing did not show a warning but I think it's best to remove that for now.
I've made the changes, thanks Christian!
Requesting Mozilla to take a look @bvandersloot-mozilla @martinthomson @cboozar.
This seems reasonable to me!
Updating the spec to repurpose confirm IDP login into click dialog button. Please take a close look, this is my first edit to the spec.
Preview | Diff