w3c-fedid / FedCM

A privacy preserving identity exchange Web API
https://w3c-fedid.github.io/FedCM/
Other
375 stars 72 forks source link

Remove note on IdP to validate nonce (#582) #583

Closed obfuscoder closed 5 months ago

obfuscoder commented 5 months ago

Preview | Diff

cbiesinger commented 5 months ago

lgtm but could you resolve the IPR issue as described in https://labs.w3.org/repo-manager/pr/id/fedidcg/FedCM/583 ?

samuelgoto commented 5 months ago

LGTM++

npm1 commented 5 months ago

Yea ideally you can fix the affiliation. But I'm also open to consider this a non-substantive change since it just removes a note

obfuscoder commented 5 months ago

As this PR is just about removing content, you could probably waive this requirement for this one. I'll try to get this IPR sorted out with my company, but it willl probably take a while.

samuelgoto commented 5 months ago

SGTM.

Waving as non-substantive.