Add AlignmentTSO - Githubissues

w3c-lbd-cg / bot

Building Topology Ontology

https://w3id.org/bot

53 stars 15 forks source link

Add AlignmentTSO #107

Open PauenN opened 3 years ago

PauenN commented 3 years ago

Add the proposed alignment from BOT v0.3.2 to TSO v0.2 as discussed at the LBD CG Call February 23.

GeorgFerdinandSchneider commented 3 years ago

Dear @PauenN ,

thank you for submitting the proposed alignments. I have some minor sugesstions for improvement. If they are fixed I am fine to merge the proposed BOT-to-TSO-Alignment:

Please rename the file to TSOAlignment; this is a convention for alignment files
Please issue a version as of semver.org: v0.2.0
Please add a version IRI for the Alignment, i.e. owl:versionIRI ;

Thank you

@mathib feel free to merge when changes have been made

PauenN commented 3 years ago

Dear @GeorgFerdinandSchneider ,

I added your suggested improvements as well as a new alignment for an object property. Could you please check the added alignment before merging.

Thanks, Nico

mathib commented 3 years ago

looks good to me. I see there's also a small addition in the alignment: tso:contains rdfs:subPropertyOf bot:hasElement .

I'll give some time to @GeorgFerdinandSchneider to check it :)

PauenN commented 3 years ago

@GeorgFerdinandSchneider @mathib I changed the alignment from tso:System rdfs:subClassOf bot:Element to tso:Component rdfs:subClassOf bot:Element. Please take this into consideration while reviewing the alignment. Thanks. :)