search

w3c-lbd-cg / bot

Building Topology Ontology
https://w3id.org/bot
53 stars 15 forks source link

Update definition of hasSubElement #47

Closed deKlerk closed 3 years ago

deKlerk commented 5 years ago

The definition of the property bot:hasSubElement needs to be updated. It now still has the older definition:

hosts element - Relation between an element a) and another element b) hosted by element a).

deKlerk commented 5 years ago

Note from LDAC2019: The hasSubElement property covers all subcomposition and aggregation (e.g. hosts). It can and should be defined as a Transitive Property.

GeorgFerdinandSchneider commented 4 years ago

Current definition is "Relation between an element a) and another element b) hosted by element a)"

mathib commented 4 years ago

Current definition (v0.3.1):

Relation between an element a) and another element b) hosted by element a)

Proposal:

Relation between two building elements, either one element hosting another (e.g. a window hosted by a wall) or a subcomposition of a building element into smaller parts (e.g. a fan as part of an air handling unit).

GeorgFerdinandSchneider commented 4 years ago

+1

maximelefrancois86 commented 4 years ago

agreed

mathib commented 4 years ago

Note from LDAC2019: The hasSubElement property covers all subcomposition and aggregation (e.g. hosts). It can and should be defined as a Transitive Property.

Just noticed that bot:hasSubElement is not yet defined as being transitive.

In addition, the following additional property chain axiom might be beneficial and correct on bot:containsElement:

owl:propertyChainAxiom ( bot:containsElement bot:hasSubElement )

GeorgFerdinandSchneider commented 4 years ago

Sounds good, should be in a upcoming version of BOT e.g. 0.4.0 or 1.0.0

maximelefrancois86 commented 4 years ago

Before integrating these two new axioms (transitivity and property chain axiom, please check that we remain in OWL 2 DL (global restriction: total order on non-simple properties https://www.w3.org/TR/owl2-syntax/#Property_Hierarchy_and_Simple_Object_Property_Expressions ) check with owlapi, maybe https://github.com/stain/profilechecker

GeorgFerdinandSchneider commented 4 years ago

The definition has been accepted as of W3C LBD CG TelCo 19 May 2020

Relation between two building elements, either one element hosting another (e.g. a window hosted by a wall) or a subcomposition of a building element into smaller parts (e.g. a fan as part of an air handling unit).

The addition of logical statements as mentioned above https://github.com/w3c-lbd-cg/bot/issues/47#issuecomment-621215340 is postponed until future revisions of BOT -> https://github.com/w3c-lbd-cg/bot/issues/74

GeorgFerdinandSchneider commented 3 years ago

Comment received by @deKlerk through comment on google spreadsheet:

the examples in the description actually describe the inverse relation of bot:hasSubElement ;) they should be used to describe the (non existent) property bot:subElementOf instead

Current:

Relation between two building elements, either one element hosting another (e.g. a window hosted by a wall) or a subcomposition of a building element into smaller parts (e.g. a fan as part of an air handling unit).

Proposal:

Relation between two building elements, either one element hosting another (e.g. a wall hosts a window) or a subcomposition of a building element into smaller parts (e.g. an air handling unit has as a part a fan).

GeorgFerdinandSchneider commented 3 years ago

-> Should be changed

GeorgFerdinandSchneider commented 3 years ago

Change the description as proposed by @deKlerk accepted W3c LBD CG meeting on 28 July 2020 (Flipping around the examples in "e.g.")

issue with property chain propose by @mathib remains -> v0.4.0 cf. above

GeorgFerdinandSchneider commented 3 years ago

closed by https://github.com/w3c-lbd-cg/bot/commit/a460732116ae06ebaac8f960b2228f355f28685a