search

w3c / ColorWeb-CG

repo for the Color on the Web Community Group
54 stars 21 forks source link

Correct some spelling, grammar, and HTML issues #55

Closed CAfromCA closed 3 years ago

CAfromCA commented 3 years ago

Corrected some minor spelling, grammar, and HTML issues. Examples include:

Replaced some special Unicode characters with their HTML encoded entities or equivalents (e.g. "2" for the Unicode superscript 2 character, "™" for the TM character).

Reformatted the HTML with a 120 character line width using Prettier.

palemieux commented 3 years ago

@svgeesus @chrisn Can you review this PR? Is the draft CG report still relevant/maintained?

chrisn commented 3 years ago

I'd prefer to see the wording issues separated from the reformatting. At is is, this PR is really hard to review.

In terms of relevance: the purpose was to provide an overview of all the places on the web platform that would need to change to support HDR. I believe there's still value in doing that - the CG has focused on Canvas recently, but there are other areas. The content of the document is somewhat outdated now though, and I don't really have time to maintain the document.

chrisn commented 3 years ago

I just made a few changes to the formatting, I'm happy to merge.

palemieux commented 3 years ago

I just made a few changes to the formatting, I'm happy to merge.

Please approve the PR

svgeesus commented 3 years ago

Merged.

I would have preferred not to see either of these changes:

Replaced some special Unicode characters with their HTML encoded entities or equivalents (e.g. "2" for the Unicode superscript 2 character, "™" for the TM character).

Reformatted the HTML with a 120 character line width using Prettier.

The first because there is no need for HTML entities, the Web is UTF-8 - except for things that are hard to edit like zero-width spaces and so on.

The second because wrapping to arbitrary line length limits breaks git history for no benefit. Short lines are good, but don't re-wrap.