search

w3c / FileAPI

File API
https://w3c.github.io/FileAPI/
Other
104 stars 44 forks source link

Modernize Blob constructor a tiny bit #125

Open annevk opened 5 years ago

annevk commented 5 years ago

All implementations do something different for new Blob(undefined, { type: "x/x" }). Let's do something simple.

Fixes #54.

Preview | Diff

annevk commented 5 years ago

I don't. I wanted to fix the general type setup, but I keep running out of time.

marcoscaceres commented 5 years ago

need to close and reopen to trigger new travis

marcoscaceres commented 4 years ago

@annevk, could you please fix the merge conflicts? The constructor can now be updated to new syntax.

annevk commented 4 years ago

Once there are sufficient tests I'm happy to address the remainder (including filing bugs).

marcoscaceres commented 4 years ago

ok, no probs. Was worried about bit rot. How about just getting it to a good state and we just don't merge until there are tests? The only thing I was unsure about was the merge conflict with the algorithm, the IDL seems like a quick fix.

marcoscaceres commented 3 months ago

@annevk, just saw this was still pending. Should this be updated and merged?

annevk commented 3 months ago

@wisniewskit did you end up doing https://github.com/whatwg/mimesniff/issues/189#issuecomment-2090884819 in Gecko? Maybe I should take some time to make the specification say that to try to move this along.

saschanaz commented 3 months ago

Looks like the plan is to change our behavior first and see whether it's web compatible, before changing WPT: https://phabricator.services.mozilla.com/D208848

wisniewskit commented 3 months ago

@annevk, I haven't yet landed the patches for Gecko to try that, as I'm still figuring out which test cases in our own codebase fail, and how to deal with them. But it's not looking intractable, so hopefully we can land it sometime soon and get data on whether there's any obvious fallout on sites. (Of course it would be faster and fairer if others also did the same, so I welcome anyone willing to help push other vendors along as well!)