search

w3c / FileAPI

File API
https://w3c.github.io/FileAPI/
Other
104 stars 44 forks source link

fix: no special character replacement in fileName #171

Closed lucacasonato closed 3 years ago

lucacasonato commented 3 years ago

Closes #41

For normative changes, the following tasks have been completed:

Implementation commitment:

See "No replacement when using special character in fileName" test at https://wpt.fyi/results/FileAPI/file/File-constructor.html?label=master&label=experimental&aligned

Preview | Diff

annevk commented 3 years ago

@lucacasonato can you resolve https://labs.w3.org/repo-manager/pr/id/w3c/FileAPI/171?

lucacasonato commented 3 years ago

@lucacasonato can you resolve https://labs.w3.org/repo-manager/pr/id/w3c/FileAPI/171?

I'm not sure I can myself. I don't have a W3C account (employer is not a W3C member), and this PR probably does not fall under the "non normative" exception because it is normative in nature. There is the section stating "the WG’s team contacts will request the contributors to sign the non-participant licensing commitments", but I don't know where I can get this "non-participant licensing commitment" to sign. According to https://github.com/w3c/ash-nazg/issues/198 I can not obtain this myself, and it "requires specific action from the staff contact". Do you know who the "staff contact" is in this case that I could contact?

annevk commented 3 years ago

I see, @marcoscaceres or @sideshowbarker, care to help out?

sideshowbarker commented 3 years ago

I'm not sure I can myself. I don't have a W3C account (employer is not a W3C member), and this PR probably does not fall under the "non normative" exception because it is normative in nature. There is the section stating "the WG’s team contacts will request the contributors to sign the non-participant licensing commitments", but I don't know where I can get this "non-participant licensing commitment" to sign. According to w3c/ash-nazg#198 I can not obtain this myself, and it "requires specific action from the staff contact". Do you know who the "staff contact" is in this case that I could contact?

I see, @marcoscaceres or @sideshowbarker, care to help out?

This is in @marcoscaceres’s realm but I think unless he’s dealt before with the process for this kind of case (I haven’t myself yet), some guidance from @wseltzer is ultimately going to be needed.

siusin commented 3 years ago

@lucacasonato , thank you for the pull.

We have a system that can help create a "non-participant licensing commitment" request, but we have to ask you to create a W3C account (which is open to the public) first, as the Repository Manager suggested. Once you have an account, there will be a button on this page: https://labs.w3.org/repo-manager/pr/id/w3c/FileAPI/171 , which will open the right form to create the commitment.

Please get a W3C Account here: https://www.w3.org/Help/Account/

lucacasonato commented 3 years ago

Hi @siusin. Registered an account now. I only see one button which is the "join the Web Applications Working Group" one. This requires me to register as an "Invited Expert" first, which requires me to fill out and submit another form, and then can take up to 10 days. After this it seems I have to fill out another form, requesting to join the Web Applications Working Group as an Invited Expert. It seems after this is done I get to sign the "non-participant licensing commitment"...

Maybe it is best if someone else takes over this 1 line change PR, as I don't think setup time here is in any relation to the size of the change 😉

Contributing to WHATWG specifications is a lot easier... just a single signature at https://participate.whatwg.org/agreement.

wseltzer commented 3 years ago

@lucacasonato we apologize for the apparent complexity, but it's not that bad. You get the licensing commitment click-through once you have a W3C account -- no invited expert application needed -- and you should have a link to that form in your inbox. Creating the W3C account lets us link the signature with the PR.

lucacasonato commented 3 years ago

Ah! That was the part I missed. There was no link to the licensing commitment form on the repo manager page (which I thought was where I would find it). Only got that email 30 minutes ago. Signed and submitted now. Thanks for the help everyone :-)

annevk commented 3 years ago

Thanks all!

\o/