w3c / FileAPI

File API
https://w3c.github.io/FileAPI/
Other
105 stars 44 forks source link

Don't export "resolve" #190

Closed johannhof closed 1 year ago

johannhof commented 1 year ago

Any spec author who wants to reference https://webidl.spec.whatwg.org/#resolve through [=resolve=] will run into conflicts with this specification, so we should either avoid exporting or specialize the name of this export.

johannhof commented 1 year ago

It seems to be used only in https://github.com/whatwg/url/blob/2f7b6881af0b69fb6ad7e6e8b4cda9514006cb35/url.bs#L1823

mkruisselbrink commented 1 year ago

I'm not sure what's wrong with being explicit when referencing definitions and referring to the other resolve as [=/resolve=]? The whole point of having "for" namespacing is so different specs can define the same terms without conflicts after all...

mkruisselbrink commented 1 year ago

Also note that you can use the Assume Explicit For if you want bikeshed to interpret [=resolve=] as [=/resolve=] automatically.

johannhof commented 1 year ago

To be clear I'm not saying that this spec is doing anything wrong, I just think that we could be good citizens and provide an ergonomic improvement (besides including the slash I've always had to add a blurb to link-defaults as well, which may just be my lack of understanding) that applies to a lot of specs.

I'm not trying to set a precedent for always avoiding collisions or anything, but in this case it seems reasonable :)