Closed inexorabletash closed 4 years ago
Ah, you're right, relevant is probably correct.
(Aside: I need to understand why NFS is using a mix of current vs. relevant.)
Relevant realm/settings object needs to be applied to a particular platform object (i.e. this
).
(which coincidently is also part of the reason of the mix of current and relevant in NFS, static methods like getSystemDirectory don't have a |this|/platform object, so relevant realm doesn't make sense in that context, hence why that uses the current settings object instead (which also matches what our bindings do for CallWith=ScriptState on static methods). Most of the other cases of current realm in NFS should probably be relevant though, I'll need to fix that...)
Closes #329
Use the formal definition for environment settings object rather than the imprecise "global scope used to access this".
No normative behavior changes, just being more precise.
Preview | Diff