search

w3c / IntersectionObserver

Intersection Observer
https://www.w3.org/TR/intersection-observer/
Other
3.62k stars 526 forks source link

[polyfill] get correct parent node for slot in shadow dom #425

Closed ennjin closed 3 years ago

ennjin commented 4 years ago

Closes #424

ennjin commented 3 years ago

@szager-chromium, @philipwalton, @dvoytenko someone can take a look at this?

ennjin commented 3 years ago

Hm, is it ready to merge?

dvoytenko commented 3 years ago

This change looks good to me. The owners of the repo still need to review and merge.

ennjin commented 3 years ago

@emilio it would be nice if you can check this :+1:

ennjin commented 3 years ago

I'm curious what is the point of fixing up the polyfill if modern browsers all support the API correctly.

Actually there are customers using legacy browsers like chrome <= 50 and safari <= 11 :smile_cat:

ennjin commented 3 years ago

@emilio Thanks for review. But I have a question, when the following changes will be bumped to npm?