Allow setting `thresholds`

w3c / IntersectionObserver

Intersection Observer

https://www.w3.org/TR/intersection-observer/

Other

3.62k stars 531 forks source link

Allow setting `thresholds` #485

Open zcorpan opened 2 years ago

zcorpan commented 2 years ago

Part of #428.

The following tasks have been completed:

[ ] Modified Web platform tests (link to pull request)

Implementation commitment:

[ ] WebKit (https://bugs.webkit.org/show_bug.cgi?id=)
[ ] Chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=)
[ ] Gecko (https://bugzilla.mozilla.org/show_bug.cgi?id=)

Preview | Diff

zcorpan commented 2 years ago

rootMargin split to https://github.com/w3c/IntersectionObserver/pull/486

I can edit this branch to only change thresholds. (Edit: done)

szager-chromium commented 2 years ago

As with modifying rootMargin, we need to specify the effect of modifying thresholds on previousThresholdIndex:

https://github.com/w3c/IntersectionObserver/pull/486#issuecomment-1086191513

domfarolino commented 1 year ago

This thread was buried in my inbox and I got to it by doing some cleaning up. Out of curiosity, is there any progress here? @zcorpan Do you plan to continue this?

zcorpan commented 1 year ago

@domfarolino if there's impl interest I can make a plan. :)

domfarolino commented 1 year ago

I see. Maybe we can just ping @szager-chromium and @emilio, and I'm not sure for Apple? ....