search

w3c / Mobile-Checker

The Mobile Checker is a tool for Web developers who want to make their Web page or Web app work better on mobile devices.
https://validator.w3.org/mobile-alpha/
MIT License
322 stars 84 forks source link

Update list of css properties needing prefixing #95

Closed dontcallmedom closed 9 years ago

dontcallmedom commented 9 years ago

ref https://github.com/w3c/Mobile-Checker/issues/47#issuecomment-114635340

gbaudusseau commented 9 years ago

Guess we will need to update our tests before merging that

gbaudusseau commented 9 years ago

seems like jsdom < 4.x is not compatible. why did we need to downgrade jsdom?

dontcallmedom commented 9 years ago

jsdom refuses to run with node.js (only io.js) in versions >= 4.x

gbaudusseau commented 9 years ago

well, that's interesting. jsdom refuses for all node version? even 0.12 ?

dontcallmedom commented 9 years ago

https://github.com/tmpvar/jsdom says

Note that as of our 4.0.0 release, jsdom no longer works with Node.js™, and instead requires io.js. You are still welcome to install a release in the 3.x series if you use Node.js™.

dontcallmedom commented 9 years ago

any reason not to merge this?

gbaudusseau commented 9 years ago

the Travis build failed no?

dontcallmedom commented 9 years ago

But not due to this change specifically as far as I can tell. Our Travis CI set up seems in a bad shape, but I wouldn't put that in front of a (fairly simple) bug fix.

gbaudusseau commented 9 years ago

makes sens :)