search

w3c / PWETF

Positive Work Environment Community Group
https://www.w3.org/community/pwe/
Other
108 stars 53 forks source link

Addressing feedback from the AC Vote #371

Closed wareid closed 4 months ago

wareid commented 4 months ago

Pulling together changes to reflect feedback from the AC Vote that is currently in progress.

Preview | Diff

wareid commented 4 months ago

I can't seem to add Mark as a reviewer, so I'm pinging here: @mnot

TzviyaSiegman commented 4 months ago

Thank you, Wendy. This looks great.

mnot commented 4 months ago

Thanks, this is an improvement.

wareid commented 4 months ago

The change based on my feedback looks good, so I'll hit 'Approve'. That said, the rest of the diff is quite hard to read; I suspect there are spurious whitespace / formatting changes mixed in with the substantive ones. That's unfortunate, and makes the diff as a whole hard to review.

Thank you! I need to set up the preview link for this repo, I got a little carried away with formatting.

wareid commented 4 months ago

@chrisn Thank you for your feedback on the AC review, I have added some editorial changes in line with the feedback, would it be possible for you to review this so I can merge this PR?

wareid commented 4 months ago

@fantasai I have addressed your suggestion in the latest commit. I cannot do anything about whitespace at this time but I will address it in a future PR dedicated to fixing all of the inconsistencies.

swickr commented 4 months ago

A reviewer submitted the following comments to the Team, requesting that the Team forward them. I think they have been adequately addressed in this PR, but documenting them here for the record:

Section 14 should be revisited for accessibility and inclusion as the language is not easily understandable, particularly to someone who's first language is not English. A suggested alternative follows.

  • Wasting others time.
  • Repeating statements which have been shown to be false.
  • Re-raising questions that have already been answered.

I have tested both the original text and the proposed replacement at https://app.readable.com/text/?demo. The original text is ranked as C and the replacement A.

wareid commented 4 months ago

@swickr Thank you for sharing the feedback, I agree that I believe the comments are addressed, but just for the benefit of the submitter, I'll provide some direct pointers that are applicable to their concerns:

Wasting others time.

We don't have a specific recommendation regarding "time" as it's a challenge to quantify considering our work mode (too much time in calls? Spent reading GitHub issues?), if the reviewer has a recommendation, or would like to explore the topic further, we recommend opening an issue in this repo so we can explore it for a future revision. I think it's a worthy topic to explore, I wouldn't want to attempt to force something in without discussion.

Repeating statements which have been shown to be false.

See section 7, and point 4 of section 14.

Re-raising questions that have already been answered.

See section 14.

Re: Readability, I don't see the proposed revised text mentioned, so I'm not sure what the suggested changes are.

fantasai commented 4 months ago

I cannot do anything about whitespace at this time

I'm only asking to update this PR so that it doesn't include unnecessary whitespace changes (so that it's easy to review what's actually changed). Not sure why that can't/shouldn't be done?