search

w3c / Unicorn

Unicorn - W3C's Unified Validator
https://validator.w3.org/unicorn/
Other
128 stars 59 forks source link

Remove Jigsaw dependent code #93

Closed vivienlacourba closed 8 years ago

vivienlacourba commented 8 years ago

Reported by vivien on 4 Jun 2010 15:18 UTC Find another way to know unicorn_home parameter (currently by a jvm parameter), whether programatically, or with web.xml

vivienlacourba commented 8 years ago

Comment by tgambet on 8 Jun 2010 17:52 UTC I removed libraries that were needed only for Jigsaw. There is not really any Jigsaw dependent code, but now that we chose not to support Jigsaw anymore we'll be able to use more methods of the servlet api, like, amongst other, methods to get the path of the application (and get rid of the jvm parameter), methods to get the url where unicorn is deployed (get ride of UNICORN_URL in the conf file), and methods to forward requests between servlet or to send redirects to the user. None of these is needed for milestone 1.0.

vivienlacourba commented 8 years ago

Comment by jean-gui on 8 Jun 2010 17:58 UTC "get rid of UNICORN_URL in the conf file" I am not sure we should do that as we can use proxies that change URLs. Or, by default Unicorn should try to guess its URL, but if UNICORN_URL is present, then the latter should be used.

vivienlacourba commented 8 years ago

Comment by tgambet on 14 Jun 2010 14:38 UTC Done, unicorn.home is now guessed by unicorn during initialization. Note that unicorn must be deployed by the servlet server and not run directly from the war in order to work properly.