search

w3c / WebID

https://www.w3.org/groups/cg/webid
MIT License
14 stars 7 forks source link

Use WebID Profile Document consistently #8

Closed csarven closed 2 years ago

csarven commented 2 years ago

Closes #4 .

Edit: Using "WebID Profile Document" consistently. Replaced all other similar occurrences with that term. Kept the existing local identifier dfn-webid_profile and dropped dfn-profile_document.

jonassmedegaard commented 2 years ago

Looks good to me.

Thanks, @csarven.

bblfish commented 2 years ago

This change indeed seems pretty uncontroversial, and we have only positive feedback on it, and no negative. So I'll just leave a day in case...

TallTed commented 2 years ago

This PR does a GREAT DEAL more than "Use WebID Profile Document consistently". I need to carefully review the whole thing, because, among other things, I know that it undoes changes that I submitted previously. Please do not merge until I submit a accepting review.

TallTed commented 2 years ago

I wonder if this just needs to be rebased against the current state?

bblfish commented 2 years ago

I wonder if this just needs to be rebased against the current state?

My UI does not show any conflict problems. This is what I see:

Screenshot 2022-09-06 at 19 30 30

TallTed commented 2 years ago

I suggested a rebase not because of conflicts, but because this #8 is undoing many changes that went in via #6, which is only clear if you put the two side-by-side.

csarven commented 2 years ago

Should be corrected now. Rebased.

TallTed commented 2 years ago

@csarven — That did it. Thank you!