search

w3c / a11y-discov-vocab

Repository for the maintenance of the schema.org accessibility property values for discoverability.
https://www.w3.org/community/a11y-discov-vocab/
Other
15 stars 8 forks source link

Addressed #92 Add new unknown states for Audio/Motion/Flashing Hazards #93

Closed clapierre closed 1 year ago

clapierre commented 1 year ago

In addition to adding the individual "unknown" options.

I notice an error with the noFlashingHazard's description which was a copy/paste from the Flashing Hazard section.

Also added some recommendation for the use of "unknown" and "none" to be used instead of the equivalent 3 separate values.

Preview | Diff

mattgarrish commented 1 year ago

@iherman do you know why the ash-nazg error thing says @clapierre needs to join the schema.org CG? He's part of the CG for this vocabulary and an admin.

mattgarrish commented 1 year ago

I can't make a comment on a paragraph before some of these changes, so I'm going to open a pull request on this pull request to suggest a few changes... 😄

w3cbot commented 1 year ago

iherman marked as non substantive for IPR from ash-nazg.

iherman commented 1 year ago

@iherman do you know why the ash-nazg error thing says @clapierre needs to join the schema.org CG? He's part of the CG for this vocabulary and an admin.

I have already seen this, and I have no idea. I usually approve these PR-s for this reasons (and this is a CG).

cc @deniak @plehegar @dontcallmedom or whoever handles this service these days...?

w3cbot commented 1 year ago

deniak marked as substantive for IPR from ash-nazg.

deniak commented 1 year ago

ash-nazg still had the repository linked to the schema.org CG. When @iherman updated the reference a while ago, the repository manager was not updated automatically. I just did it and the IPR check passes now.

deniak commented 1 year ago

See: https://labs.w3.org/repo-manager/pr/id/w3c/a11y-discov-vocab/93

iherman commented 1 year ago

ash-nazg still had the repository linked to the schema.org CG. When @iherman updated the reference a while ago, the repository manager was not updated automatically. I just did it and the IPR check passes now.

Thanks a lot, @deniak !

mattgarrish commented 1 year ago

Thanks @deniak!

clapierre commented 1 year ago

Looks great Matt, @gregoriopellegrino & @madeleinerothberg Do you all agree this works for you with Matt's changes. I think its a big improvement.

mattgarrish commented 1 year ago

I'm going to merge this and then fix any conflicts with the i18n request. I should then be able to get these published. I'm going to get the crosswalk published through the official w3c process this time.

gregoriopellegrino commented 1 year ago

Great for me, thank you!