w3c / a11y-discov-vocab

Repository for the maintenance of the schema.org accessibility property values for discoverability.
https://www.w3.org/community/a11y-discov-vocab/
Other
15 stars 8 forks source link

updates to unknown values #94

Closed mattgarrish closed 1 year ago

mattgarrish commented 1 year ago

I ended mostly rewriting the intro to the hazards section to try and better explain all the possibilities we now have. I also updated the example and added two new ones to show some different permutations rather than have text explanations.

Otherwise, I had to update the lists of which properties must not / should not be used together, as they needed to account for the unknown values.


Preview | Diff

mattgarrish commented 1 year ago

@clapierre there are links to a preview and diff in the first comment. Are they not working for you?

What do you think about re-ordering the values a bit? Right now we group them in quasi-alphabetic order, but placing all the positive/negative/unknown values indidvidually together:

flashing
noFlashingHazard
unknownFlashingHazard
motionSimulation
noMotionSimulationHazard
unknownMotionSimulationHazard
sound
noSoundHazard
unknownSoundHazard
unknown
none

It might be easier to follow if we separate each group of positive, negative, unknown values like this:

flashing
motionSimulation
sound
none
noFlashingHazard
noMotionSimulationHazard
noSoundHazard
unknown
unknownFlashingHazard
unknownMotionSimulationHazard
unknownSoundHazard
clapierre commented 1 year ago

Oh missed that first comment with the preview. works great.

Yeah I also wondered about that. I think you may be right lets reorder them.

mattgarrish commented 1 year ago

I ended up going one step further and made it more like the accessibility features by adding grouping sections, so it's now:

Hazard terms
 - flashing
 - motionSimulation
 - sound
No hazard terms
 - none
 - noFlashingHazard
 - noMotionSimulationHazard
 - noSoundHazard
Unknown hazard terms
 - unknown
 - unknownFlashingHazard
 - unknownMotionSimulationHazard
 - unknownSoundHazard

I'll merge this into your pull request so we can view all the changes together.