Closed anssiko closed 3 years ago
Drive-by LGTM
I think these are the rest, PTAL:
In particular, look at the one-to-many relationship in orientation-sensor. I'm not sure if we have other similar features using Permissions Policy.
Thanks @reillyeon, I merged those PRs that received review.
Two PRs remain open:
https://github.com/w3c/ambient-light/pull/68 is per https://github.com/w3c/webappsec-permissions-policy/blob/main/features.md#standardized-features @reillyeon can you confirm the implementation status?
https://github.com/w3c/proximity/pull/52 has not been implemented and is not in the Permissions Policy registry. We may want to add this Permissions Policy bit for consistency and add a note for the implementation status. IIRC an early implementation received a Blink ItI long time ago but was an experimental feature developed in a branch looking for stronger developer pull and use cases.
Thanks @sideshowbarker! I'll merge also this one and the group will review the remaining open PRs https://github.com/w3c/ambient-light/pull/68 and https://github.com/w3c/proximity/pull/52 separately.
Fix #60
See also https://www.w3.org/2021/04/08-dap-minutes.html#r01
After some thought, I felt it is clearer to define this in each concrete sensor spec, rather that use inheritance. If this looks good, I'll replicate this to the other concrete sensor specs.
I felt this one-liner fits into the existing section, instead of a new "Permissions Policy Integration" section.
Preview | Diff