w3c / accname

Accessible Name and Description Computation
https://w3c.github.io/accname/
61 stars 23 forks source link

Specify behavior when following a hidden subtree via aria-labelledby … #150

Closed jaragunde closed 2 years ago

jaragunde commented 2 years ago

…or -describedby.

This proposal tries to bring the spec closer to the actual behavior of the different user agents. In general, user agents expose hidden content when following an aria-labelledby or -describedby relation into a hidden subtree. There are differences between engines, though.

This is a summary of what user agents will need to change to comply with this text update:

Thanks in advance for your time and feedback.

Closes #57.


Preview | Diff

jaragunde commented 2 years ago

I've setup my account as requested, feel free to "revalidate". Thanks!

MelSumner commented 2 years ago

I'm looking at these use cases in a CodePen, apologies for the review delay.

jaragunde commented 2 years ago

@jcsteh: Exactly, that's the difference between the previous wording and the new one.

jaragunde commented 2 years ago

@MelSumner: thanks for the CodePen, it's very useful!

MelSumner commented 2 years ago

Not sure why it was marking some changes as conflicted, but I think they are resolved now.

jnurthen commented 2 years ago

@MelSumner I thought we were waiting for @cookiecrook and @cyns reviews

cookiecrook commented 2 years ago

@MelSumner I thought we were waiting for @cookiecrook and @cyns reviews

Merging provides additional motivation. 🤣

jaragunde commented 2 years ago

Thanks for the review, I definitely agree with all your suggestions, some are even mistakes on my side caused by writing over and over.

To be more clear, I cannot think of a better suggestion for "root of the traversal". I would agree to revert it back to the term originally used, and keep track of what it means and how to enhance it in #148.