search

w3c / accname

Accessible Name and Description Computation
https://w3c.github.io/accname/
61 stars 23 forks source link

fix: revert changes introduced by bb65de #172

Closed jnurthen closed 1 year ago

jnurthen commented 1 year ago

https://github.com/w3c/accname/commit/bb65de313a893e3a4b9d4522deb1d049c114584e introduced changes which are part of https://github.com/w3c/accname/pull/168 and have not yet been agreed. This PR reverts those changes

Preview | Diff

spectranaut commented 1 year ago

Ok, looks good! :) probably we should make it the norm to not push to directly to main and only create PRs, even for editorial work, to avoid these kind of overlooks? @accdc

accdc commented 1 year ago

"Ok, looks good! :) probably we should make it the norm to not push to directly to main and only create PRs, even for editorial work, to avoid these kind of overlooks?"

That's fine with me, though I am confused why you think I changed all these things to begin with. https://github.com/w3c/accname/commit/bf517241fe7f820d989ab772d0bc9e620540cd69

jnurthen commented 1 year ago

The revert commit was https://github.com/w3c/accname/commit/bb65de313a893e3a4b9d4522deb1d049c114584e which includes other changes