Closed jnurthen closed 7 months ago
ok! @accdc let's schedule some time to get on the same page about this and come up with an action plan. 👍
Implementation test results: https://wpt.fyi/results/webdriver/tests/get_computed_label/get.py?label=master&label=experimental&aligned
Source for those label and role tests: https://github.com/web-platform-tests/wpt/blob/c478d0f4a1/webdriver/tests/get_computed_label/get.py https://github.com/web-platform-tests/wpt/blob/c478d0f4a1/webdriver/tests/get_computed_role/get.py
Implemented in Chromium and WebKit.
Gecko tracker: https://bugzilla.mozilla.org/show_bug.cgi?id=1788867
Docs on running the WPT tests: https://github.com/web-platform-tests/wpt/blob/c478d0f4a1c3cd64a35b6f451679365dddbed8f5/README.md
Taking assignment as this is likely to be part of the InterOp 2023 Accessibility Investigation.
FWIW, the Mac configuration steps on the WPT site didn't work for me, so here's my variant of what worked.
% which python3
should return /usr/bin/python3
export PATH="$( xcrun python3 -m site --user-base )/bin:$PATH"
cd
to a directory where you want the WPT source to live, then:
xcrun git clone https://github.com/web-platform-tests/wpt.git
xcrun pip3 install --user virtualenv
cd wpt
sudo /Applications/Safari\ Technology\ Preview.app/Contents/MacOS/safaridriver --enable
./wpt make-hosts-file | sudo tee -a /etc/hosts
python3 ./wpt run --log-mach-level debug --log-mach - --webdriver-arg="--diagnose" safari /webdriver/tests/get_computed_label/get.py
You should get some percentage of passes and failures. The specific passes/failures should match the results on WPT.fyi for the same test.
Note: Watch out for double hyphens in CLI params. Depending on the text field you copy out of, autocorrect may convert them to en dashes (–) which can look identical in monospace.
testdriver extension PR here: https://github.com/web-platform-tests/wpt/pull/38758/files
Once that lands, you should be able to do:
python3 ./wpt run --log-mach-level debug --log-mach - --webdriver-arg="--diagnose" safari /accname/basic.html
python3 ./wpt run --log-mach-level debug --log-mach - --webdriver-arg="--diagnose" safari /aria/role/basic.html
It should work in Chromium, too. Gecko has the prerequisite webdriver support planned for the April/May timeframe.
Firefox patch here: https://bugzilla.mozilla.org/show_bug.cgi?id=1585622#c21 🎉
Work continues in the following:
Should we close this AccName #174 issue as completed?
I think this is done now... There are currently 382 AccName tests among the other WPT Accessibility tests. Closing.
all the accname tests should be able to be rewritten to use webdriver.