w3c / accname

Accessible Name and Description Computation
https://w3c.github.io/accname/
61 stars 23 forks source link

Step 2C includes controls with value that are directly referenced by labelledby or describedby #183

Closed smhigley closed 2 months ago

smhigley commented 1 year ago

Closes #179, based on discussed resolution

Updates the wording of 2C to specify returning the value text of all controls that allow users to control their value, whether or not they are embedded within a referenced label, or are the referenced label. This is the current real-world behavior of all tested browsers.

I also included controls that are part of an aria-describedby calculation, since in testing FF, Chrome, Edge, and Safari, all browsers implement this in practice as well (ref: https://jsfiddle.net/tfogpnvj/ for a reduced example).

PR tracking

Check these once you have confirmed the related change is not necessary (also add N/A) OR when the relevant issue or PR has been made. Leave uncheck if you are unsure. Read the Process Document or Test Overview for more information.

Implementation tracking


Preview | Diff

spectranaut commented 1 year ago

@MelSumner I think this is ready for merge! Not waiting for any dependent changes.

MelSumner commented 1 year ago

@smhigley could you rebase? Once it's green we're ready to merge.

MelSumner commented 8 months ago

👋 @smhigley We'd love to get this rebased for a merge, would you be able to do that?

MelSumner commented 2 months ago

This PR has been moved to the mono repo: https://github.com/w3c/aria/pull/2210