search

w3c / accname

Accessible Name and Description Computation
https://w3c.github.io/accname/
61 stars 23 forks source link

change computation ULs to OLs #188

Closed cookiecrook closed 1 year ago

cookiecrook commented 1 year ago

resolves #185

pls merge #187 first, as this one branched from it

cookiecrook commented 1 year ago

@spectranaut I noticed when starting this new PR that the template completely overwrites the multi-line commit message. It used to append the template to the commit message. What that a purposeful change? Since ~last week IIRC.

spectranaut commented 1 year ago

@spectranaut I noticed when starting this new PR that the template completely overwrites the multi-line commit message. It used to append the template to the commit message. What that a purposeful change? Since ~last week IIRC.

I tried to see if you could preserve the commit messages while using a PR template, but there doesn't seem to be an option!

cookiecrook commented 1 year ago

@jnurthen @spectranaut merge #187 then this one? thx