Update to Condition for step 2C

OisinNolan commented 4 years ago

This PR broadens the condition for step 2E such that it applies to controls embedded in nodes that allow name from content as well as controls that are embedded in labels.
Embedded in label and Embedded in node that allows name from content may then be merged and simplified to descendant of node whose accessible name / description is being computed, as is done in the PR.

This PR is motivated by the fact that many (all?) AccName implementations interpret step 2E in this manner. See example:

:boom: Error: 500 Internal Server Error :boom:

PR Preview failed to build. (Last tried on May 16, 2021, 3:07 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one: :rotating_light: [Spec Generator](https://www.w3.org/2015/labs/) - Spec Generator is the web service used to build specs that rely on ReSpec. :link: [Related URL](https://labs.w3.org/spec-generator/?type=respec&url=https%3A%2F%2Frawcdn.githack.com%2FOisinNolan%2Faccname%2Fbeeb3d59364035373d642da35b6a6dc4e3bf323d%2Findex.html%3FisPreview%3Dtrue) ``` 😭 Sorry, there was an error generating the HTML. Please report this issue! Specification: https://rawcdn.githack.com/OisinNolan/accname/beeb3d59364035373d642da35b6a6dc4e3bf323d/index.html?isPreview=true&publishDate=2021-05-16 ReSpec version: 25.6.0 File a bug: https://github.com/w3c/respec/ Error: Error: Evaluation failed: Timeout: document.respec.ready didn't resolve in 27421ms. at ExecutionContext._evaluateInternal (/u/spec-generator/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:221:19) at runMicrotasks () at processTicksAndRejections (internal/process/task_queues.js:93:5) at async ExecutionContext.evaluate (/u/spec-generator/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:110:16) at async generateHTML (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:276:12) at async toHTML (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:92:18) at async Object.generate [as respec] (/u/spec-generator/generators/respec.js:14:44) at async /u/spec-generator/server.js:205:44 ``` _If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20w3c/accname%2390.)._

Preview | Diff