w3c / activitystreams

Activity Streams 2.0
https://www.w3.org/TR/activitystreams-core/
Other
279 stars 61 forks source link

Example 146: Missing `Z` in startTime #445

Open cjslep opened 6 years ago

cjslep commented 6 years ago

Please Indicate One:

Please Describe the Issue:

https://www.w3.org/TR/activitystreams-core/#dates states:

An uppercase "T" character must be used to separate date and time, and an uppercase "Z" character must be used in the absence of a numeric time zone offset.

However, in https://www.w3.org/TR/activitystreams-vocabulary Example 146 is:

{
  "@context": "https://www.w3.org/ns/activitystreams",
  "summary": "Sally became a friend of Matt",
  "type": "Create",
  "actor": "http://sally.example.org",
  "object": {
    "type": "Relationship",
    "subject": "http://sally.example.org",
    "relationship": "http://purl.org/vocab/relationship/friendOf",
    "object": "http://matt.example.org",
    "startTime": "2015-04-21T12:34:56"
  }
}

Which is missing both the numeric time zone offset and the Z.

sebilasse commented 6 years ago

just btw - in my personal JSON schemas it fails as well. To test :

"xsd$dateTime": {
  "type": "string",
  "format": "date-time",
  "pattern": "^(-?(?:[1-9][0-9]*)?[0-9]{4})-(1[0-2]|0[1-9])-(3[01]|0[1-9]|[12][0-9])T(2[0-3]|[01][0-9]):([0-5][0-9]):([0-5][0-9])(\\.[0-9]+)?(Z|[+-](?:2[0-3]|[01][0-9]):[0-5][0-9])?$"
}
evanp commented 6 years ago

This is an error; we should add it to our ERRATA

evanp commented 6 months ago

I added a PR to add an erratum for this error. We'll consider it at a future CG meeting, and if approved, it will go into the ERRATA.md document and also the editor's draft.

ThisIsMissEm commented 1 month ago

Pull request at: https://github.com/w3c/activitystreams/pull/590/files