search

w3c / activitystreams

Activity Streams 2.0
https://www.w3.org/TR/activitystreams-core/
Other
279 stars 61 forks source link

Fix example 183 lat/lon values to Numbers, not String #451

Open gobengo opened 6 years ago

gobengo commented 6 years ago

Resolves #446

kaleb commented 4 years ago

Shouldn't this have been fixed in the file https://github.com/w3c/activitystreams/blob/master/test/vocabulary-ex183-jsonld.json instead? And the re-gen the php @gobengo ?

gobengo commented 4 years ago

@kaleb I don't believe the index.html is generated from those example json files.

Also have no idea why @evanp closed this. Still seems right to have those be numbers and not strings. All the other uses of the latitude/longitude properties in the vocabulary document use numbers.

dontcallmedom commented 4 years ago

The problem was documented in the errata from what I can see: https://github.com/w3c/activitystreams/commit/3b5df7a12eac0851ebfc50daeefdd51f47f2d919

That said, fixing the main HTML file itself would still make sense I think, so re-opening the pull request (at the very least, documenting why it should be closed would be better)