Open xenomachina opened 1 year ago
Also, given that orderedItems
appears in this list, I wonder if:
nameMap
, summaryMap
, and contentMap
, should be added to this listpreferredUsernameMap
should be added to §4.1 ActivityPub.This PR implements the proposed fixes from above.
'as:attachment' and 'as:attachments' are both in the owl https://github.com/w3c/activitystreams/blob/master/vocabulary/activitystreams2.owl#L52
notably the referent of the @context
URI does not mention attachments
bengo@bengo ~ ⚡ curl -H "Accept: application/json" https://www.w3.org/ns/activitystreams | grep attachment
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 7985 100 7985 0 0 18320 0 --:--:-- --:--:-- --:--:-- 18398
"attachment": {
"@id": "as:attachment",
ah but there is also this other file activitystreams1-context.jsonld
that does define attachments
https://github.com/w3c/activitystreams/blob/master/ns/activitystreams1-context.jsonld#L9C25-L9C25
@xenomachina this works pretty well. I think the principle that we should only include terms on this page that are defined in the context document is a righteous one.
We have a generator script in the GitHub repository. I'm going to re-run the script to make sure things compare correctly.
Since this is a non-normative document, we can make this change relatively easily.
Please Indicate One:
Please Describe the Issue:
ActivityStreams 2.0 Terms, in §3. Property Definitions, contains a list of AS2.0 property names, each of which links to its definition in Activity Vocabulary.
The following properties appear in this list, but have broken links:
attachments
author
downstreamDuplicates
orderedItems
provider
rating
tags
upstreamDuplicates
verb
I searched in the following documents to see if I could find any mention of these properties:
Here's what I found:
The following properties are only mentioned in JSON Activity Streams 1.0:
attachments
author
provider
rating
tags
They are not mentioned at all in any of the AS 2.0 documentation that I can see (except for this list). There are other properties in AS1.0 that were removed but which are not mentioned in this list.
Suggested fix: remove these from the list.
The following properties...
downstreamDuplicates
verb
upstreamDuplicates
...are mentioned in Activity Streams 2.0, but only as being deprecated:
There are other deprecated properties (like
objectType
) mentioned in the same place which are not mentioned in this list.Suggested fix: remove these from the list.
Finally,
orderedItems
is not mentioned in Activity Vocabulary except in examples.However, it is documented in Activity Streams 2.0 in §4.6 Collection.
Suggested fix: update the link.