search

w3c / activitystreams

Activity Streams 2.0
https://www.w3.org/TR/activitystreams-core/
Other
276 stars 61 forks source link

Is there a minor mistake in the Remove example? #534

Open sfolsom opened 1 year ago

sfolsom commented 1 year ago

Should this (https://github.com/w3c/activitystreams/blob/54a6723ed1c8b95a12997b4e73100308e267fc8f/test/vocabulary-ex28-jsonld.json#L11) be using the as:origin property rather than as:target?

See: https://github.com/w3c/activitystreams/blob/54a6723ed1c8b95a12997b4e73100308e267fc8f/vocabulary/index.html#L1510.

csarven commented 1 year ago

It seems to be that origin ("from") would be more fitting than target ("to") for the Remove activity, and that example.

Remove object from location.

Add object from location to location. Remove object from location. Delete object from location. Move object from location to location. ...

pietercolpaert commented 1 year ago

I came here to open exactly this issue. The description text is correct, but the Remove example was probably wrongly copy pasted from the Add example.

evanp commented 1 year ago

So, it seems like an error in the example code. The correct resolution is to add an erratum that says "target" should be "origin" in this example.

Unfortunately, ActivityPub defines the Remove activity to use "target". So, we will probably need to recommend that implementers support "origin" by default, and "target" as a fallback, regardless of the unfortunate illogic of it.