Add resolver for tracking first required AT Version

w3c / aria-at-app

Test runner and results reporter for ARIA-AT

http://aria-at.w3.org/

Other

35 stars 15 forks source link

Add resolver for tracking first required AT Version #1051

Closed howard-e closed 5 months ago

howard-e commented 6 months ago

This PR adds support for tracking "First Required AT Versions as outlined in #792.

Includes firstRequiredAtVersion on graphql schema's TestPlanVersion. When provided an AT id, given that a report has been generated for that test plan version with that AT, it will follow defined rules to return the first required AT version for a TestPlanVersion once it has gotten to RECOMMENDED.

Since this is work is also dependent on a "primary test plan run", this is branched off of the work being done on #1001.

alflennik commented 5 months ago

Cannot read properties of undefined while querying the new field.

I got this error with the query

query { 
  testPlanVersions {
    id
    title
    versionString
    firstRequiredAtVersion(atId: 1) {
            id
    }
  }
}

Any idea what might be causing this?

This is with a fresh database and the sample data.

howard-e commented 5 months ago

I got this error with the query
query { 
  testPlanVersions {
    id
    title
    versionString
    firstRequiredAtVersion(atId: 1) {
          id
    }
  }
}
Any idea what might be causing this?

This is with a fresh database and the sample data.

https://github.com/w3c/aria-at-app/pull/1051/commits/21a0c72ac25921d84de96cee99ad3125a41d3cfa should fix this. Because of how the testPlanVersionsResolver is done, the testPlanReports and phase variables were being left out which would then throw the error.