search

w3c / aria-at-app

Test runner and results reporter for ARIA-AT
http://aria-at.w3.org/
Other
35 stars 15 forks source link

feat: Restructure APG Support Tables #1053

Closed Paul-Clue closed 2 months ago

Paul-Clue commented 3 months ago

see issue #https://github.com/w3c/aria-practices/issues/2971

This pull request changes the structure of the support tables. The rows are now AT and browser combinations and the columns are now "MUST" and "SHOULD" assertions. The support percentage now represents the degree of support for "MUST" assertions and "SHOULD" assertions.

alflennik commented 3 months ago

So I think the design still looks pretty good, but I was wondering @isaacdurazo, given that this is by far the most public representation of the ARIA-AT projects work, if you have any ideas to spruce it up? One possible tweak might be "MUST" and "SHOULD" being all caps, in the past we've gotten accessibility notes about all caps words being hard for people with dyslexia to read. I do wonder if "Must Assertions" or something like that might be easier to understand? But the main thing motivating me to ask for your input is just the VoiceOver for macOS 14.2 - Safari part, is seems like we could improve it somehow.

What the new embed looks like embedded in the APG website.
isaacdurazo commented 2 months ago

I'm very sorry for my late response, @alflennik. In terms of look and feel I'm hesitant to move away from what we currently have because we need to follow how APG looks like.

With regard to your suggestions for copy changes, I agree MUST and SHOULD should definitely not be all caps, and adding some extra context would be great. I've honestly always felt confused about the meaning of Must and Should and I'm not sure going with something like "Must Assesrtions" makes sense. When looking at a report in ARIA AT, like this one, these are under a column labeled as "Priority", so with that in mind should we maybe do something like "Priority: Must"?

About the VoiceOver for macOS 14.2 - Safari part. I do have some ideas I've been thinking for ARIA AT that could be implemented here as well, which is that it would be nice to maybe have the browser and AT logos. Something super subtle, like a single color?

Paul-Clue commented 2 months ago

This pull request is ready for review.

ccanash commented 2 months ago

Latest submitted PR addresses https://github.com/w3c/aria-practices/issues/3017

howard-e commented 2 months ago

The APG TF discussed this on May 21, 2024 and confirmed this work is now ready to be merged. I will be merging this later today.

mcking65 commented 2 months ago

@howard-e I thought the tables would update on the APG site when this merged. The old tables are still being rendered. Do we need to change something in the APG content?

howard-e commented 2 months ago

@mcking65 this work being merged into the development branch makes it immediately available for the staging environment. It will become available to the production environment that APG targets once this is merged to main but no content change will be required of the APG then.