I changed all of the string constants in the UI code, updated the getMetrics function to use the updated terms in its __Formatted template strings, and added a migration for updating the testPlanReports.metrics.__Formatted in the database.
I stopped myself short of renaming variables and properties. I felt that the term passed was still useful for understanding the purpose of the variables. I do not have a strong take on this and I am open to expanding these changes to include variable names.
To see the specific tasks where the Asana app for GitHub is being used, see below:
stalgiag
commented
1 month ago
This PR addresses #1145
I changed all of the string constants in the UI code, updated the
getMetricsfunction to use the updated terms in its__Formattedtemplate strings, and added a migration for updating thetestPlanReports.metrics.__Formattedin the database.I stopped myself short of renaming variables and properties. I felt that the term
passedwas still useful for understanding the purpose of the variables. I do not have a strong take on this and I am open to expanding these changes to include variable names.